Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gradle precompiled script plugin sample #158

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Add Gradle precompiled script plugin sample #158

merged 1 commit into from
Sep 22, 2022

Conversation

vlsi
Copy link
Collaborator

@vlsi vlsi commented Sep 17, 2022 •
edited
Loading

Summary

The sample checks if dev.sigstore.sign works in a precompiled script plugin.
See https://docs.gradle.org/current/userguide/custom_plugins.html#sec:precompiled_plugins

Sample failure without "implementation->api" change: https://github.com/sigstore/sigstore-java/actions/runs/3073604928/jobs/4965846636#step:7:164

Release Note

NONE

Documentation

NONE

@vlsi vlsi force-pushed the precompiled_plugin branch from 8569860 to 66dc2c0 Compare September 17, 2022 13:58
@vlsi vlsi force-pushed the precompiled_plugin branch from 66dc2c0 to 1cf0662 Compare September 17, 2022 14:05
@vlsi vlsi requested a review from loosebazooka September 17, 2022 14:30
loosebazooka
loosebazooka approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this, but I'm not convinced it's strictly necessary to document this. This just seems like how to do script plugins in general? But I guess it adds more to the sandbox test cases?

@vlsi
Copy link
Collaborator Author

vlsi commented Sep 22, 2022

This just seems like how to do script plugins in general?

exactly.

Then it is the way to test and ensure that dependency on project(":sigstore-gradle:sigstore-gradle-sign-base-plugin") is api, not implementation.

@vlsi vlsi merged commit 232c7bc into sigstore:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loosebazooka loosebazooka loosebazooka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlsi @loosebazooka