Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused and redundant deps #186

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Fix unused and redundant deps #186

merged 1 commit into from
Oct 19, 2022

Conversation

loosebazooka
Copy link
Member

Signed-off-by: Appu Goundan appu@google.com

@loosebazooka
Fix unused and redundant deps
7efbec8 
Signed-off-by: Appu Goundan <appu@google.com>
@loosebazooka loosebazooka requested review from vlsi and patflynn October 19, 2022 11:06
@vlsi
Copy link
Collaborator

vlsi commented Oct 19, 2022 •
edited
Loading

By the way, how does that even compile?
Nevermind, testImplementation(project(":sigstore-testkit")) was declared twice.

I think dependency on sigstore-teskit was needed for @EnabledIfOidcExists annotation which is declared in sigstore-testkit:

sigstore-java/sigstore-java/src/test/java/dev/sigstore/KeylessTest.java

Line 55 in 80c21e5

@EnabledIfOidcExists(provider = OidcProviderType.MANUAL)

@loosebazooka loosebazooka merged commit 02d1a40 into main Oct 19, 2022
@loosebazooka loosebazooka deleted the remove-dep branch October 19, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlsi vlsi vlsi approved these changes

@patflynn patflynn Awaiting requested review from patflynn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loosebazooka @vlsi