Use processIsolation for SigstoreSignFilesTask to avoid OutOfMemory: MetaSpace #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
force-pushed
the
process_isolation
branch
from
1394410
to
f60fab0
Compare
…MetaSpace see gradle/gradle#18313 Signed-off-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
vlsi
force-pushed
the
process_isolation
branch
from
f60fab0
to
9b57343
Compare
patflynn
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See bcgit/bc-java#1254
BouncyCastle creates
BC Entropy Daemonthread that prevents class unloading.So we can't really use
classloader isolationin Gradle plugin.process isolationsolves the issue for Gradle plugin, however, the ones who usesigstore-javawill have to implement similar workarounds or prevent loadingsigstore-javafrom multiple classloaders.Release Note
NONE
Documentation
NONE