Exception handling: Wrap illegal state exception #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
loosebazooka
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For some malformed PEM section, the Base64 encoder of bouncy castle used by the sigstore java could throw an illegal state exception. As it is a runtime exception, JVM don’t requires it to be specifically caught, thus it does not appear in the auto-generated Javadoc and it is also assuming that exception should throw to the user. But since it is used by sigstore java as an API, it is better to wrap it with sigstore java exception.
Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=57336
Release Note
Documentation