v1 tuf client #415
Merged
v1 tuf client #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patflynn
previously approved these changes
Apr 14, 2023
|
|
||
| public Builder usePublicGoodInstance() { | ||
| if (remoteMirror != null || trustedRoot != null) { | ||
| throw new IllegalStateException(); |
There was a problem hiding this comment.
maybe just a message here explaining why you're throwing.
| } | ||
|
|
||
| public SigstoreTufClient build() throws IOException { | ||
| Preconditions.checkState( |
There was a problem hiding this comment.
why not just accept 0 as no caching?
Signed-off-by: Patrick Flynn <patrick@chainguard.dev>
Signed-off-by: Appu Goundan <appu@google.com>
loosebazooka
force-pushed
the
v1-tuf-client
branch
from
c52f1ab to
8499567
Compare
patflynn
approved these changes
Apr 14, 2023
patflynn
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of patricks work on this.
This is the sigstore wrapper around the Updater. It's very barebones right now, but it should allow us to easily access key/cert material defined in the trusted_root.json easier. This should also implement an interface that is passed to all verifiers (not yet defined).