Update signing result to store leaf certs only #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
force-pushed
the
handle-leaf-certs
branch
from
8f45e9b to
9222587
Compare
create bundles with only leaf certificates hand verification of certs in both situations - only untrusted certs (current behavior) - full cert chain to fulcio root (legacy) also move SigningCert object, it was a pointless wrapper around CertPath Signed-off-by: Appu Goundan <appu@google.com>
loosebazooka
force-pushed
the
handle-leaf-certs
branch
from
9222587 to
1f94cff
Compare
loosebazooka
changed the title
vlsi
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: https://github.com/sigstore/protobuf-specs/blob/main/protos/sigstore_common.proto#L177-L179
create bundles with only leaf certificates
handle verification of certs in both situations
also move SigningCert object, it was a pointless
wrapper around CertPath
look at #522 and #524 first