fix getMetricsAsArray type (#477)

* fix getMetricsAsArray type * add changelog for getMetricsAsArray type fix * move changelog to correct section Co-authored-by: thierry <thierry@tumblr.com>
siimon · Nov 13, 2021 · 3ad3f3f · 3ad3f3f
1 parent 05e5c3b
commit 3ad3f3f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,8 @@ project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Changed
 
+- types: fixed type for `registry.getMetricsAsArray()`
+
 - changed: typedef for pushgateway to reflect js implementation.
 
   Pushgateway's typedef were missing promise return type. That was

diff --git a/index.d.ts b/index.d.ts
@@ -34,7 +34,7 @@ export class Registry {
 	/**
 	 * Get all metrics as objects
 	 */
-	getMetricsAsArray(): Promise<metric[]>;
+	getMetricsAsArray(): metric[];
 
 	/**
 	 * Remove a single metric