Add function for setting a Histogram to zero for given labels #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbjornson
requested changes
Jan 23, 2021
There was a problem hiding this comment.
Excellent, thank you, this will fix #409. A few quick requests - can you please:
- Add the new function to index.d.ts
- Add a short mention in the readme
- Rebase on master
If you don't have time or I don't hear back in a few days, I can make these changes.
lukasstockner
force-pushed
the
add-histogram-label-zero
branch
from
89c531f
to
73c6047
Compare
lukasstockner
force-pushed
the
add-histogram-label-zero
branch
from
73c6047
to
a64aeee
Compare
|
I'd love to use this. Unfortunately it's not on npm yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PR #139, histograms are initialized to zero if they do not use any labels - however, there currently is no way to do the same for histograms with labels (without directly accessing the internals of the histogram from the outside, which is of course not a great solution).
Therefore, this PR adds a function that lets the user explicitly zero out the metrics for given labels. Since prom-client has no way of knowing what the values of the labels can be, it's up to the user to call this with all expected values.