Skip to content

Commit

Permalink
fix(rules): Expand array before shell expansion to dedup list
Browse files Browse the repository at this point in the history
Parameter expansion flags are ignored in here-word syntax, causing
duplicate files to potentially reach the `install` command ... which
objects strenuously.

Follow up question here: https://unix.stackexchange.com/q/694823/1925
  • Loading branch information
alerque committed Mar 17, 2022
1 parent b4d48e9 commit f6fca73
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rules/utilities.mk
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ install-dist: $$(or $$(call extantfiles,$$(DISTFILES)),fail)
set -o extendedglob
export VERSION_CONTROL=none
extants=($(addsuffix ($(hash)qN),$(DISTFILES)))
$(XARGS) -r install -m0644 -t "$(DISTDIR)" <<< $${(u)extants}
$(XARGS) -r install -m0644 -t "$(DISTDIR)" <<< $${$${(u)extants}}

.PHONY: debug
debug:
Expand Down

0 comments on commit f6fca73

Please sign in to comment.