Cleaner builds #13
Merged
Cleaner builds #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
@simoncozens You online? I think I'm going to go ahead with this so I can cut SILE v0.10.3 — the dot-2 tarball is badly broken for people wanting to do source builds (only works --with-system-luarocks) so I'm kind of in a hurry to replace it. The only changes here are build related, and I've tested the build in SILE ( |
|
Sorry - LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I understand it these bits that get build from scratch by autoreconf shouldn't be tracked in git at all. Since they update to the system's version on build anyway all they do is make it hard to track actual changes in the repository.
Between dropping the generated files and ignoring the rest of the generated artifacts, downstream packaging systems look a lot happier.