Port to MSVC with CMake script #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
1. Add Win32 compatible header of dirent.h, unistd.h. Create a new win32.h to put other compatibility definitions.
2. Remove the folder in the include statement of libtexpdf/{libexpdf.h,config.h} since actually this directory does not appear in the repository.
3. change `off_t` to `off64_t` since the original type is defined to 32-bit integer in Windows and hard to change.
4. Remove invalid WIN32 macro blocks, including calling `fsyscp_fopen`, `win32_vfprintf`. (these function does not exist)
5. Other small fixes like adding missing header.
|
Works for me with the new commit (2405616) to allow building on OS X. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a supporting PR for the one in SILE. Please refer to sile-typesetter/sile#567 for an overview of the big picture.
Note:
off_tare changed intooff64_tentirely, because Windows have a definition foroff_tto 32-bit integer and it's hard to override.IS_KANJIfunction indpxfile.c. Looks like it's jumping one byte if its a Chinese character in the spawn argument. This is hacky so I commented it anyway. May need fix in the future for non-Latin support.