Fix font name in javanese example #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this fix. I seem to have broken it in 59294fe by swapping out the font without committing the change to the sample. |
alerque
approved these changes
Dec 1, 2023
|
Besides merging this I added a fallback font for the Arabic numerals in the example. An example text that stuck to the language numbering system would probably be better if anybody knows how to do it correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Javanese example displayed on the website (https://sile-typesetter.org/examples/global/) is currently broken. Because the font cannot be found.
This PR fixes the name of the font (so as to match what is installed at build time) hence fixes the rendering of the Javanese parts. Unfortunately, said font does not seem to have any glyph for Arabic numerals. I’m not sure what would be an acceptable fix here.