Add Symbola as fallback for math in code samples #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mystery solved. Rendering the documentation for the color-fonts package was replacing the shaper, hence killing off any ability to use font fallbacks. See #1244. I'm fixing it only enough so that documenting it doesn't trigger the shaper being replaced, not actually fixing the incompatibility. |
|
What a yak shave. Fixing the font used for one glyph in the math documentation has turned up bug after bug, first in the package loader in general, now in the Japanese / Tate / Ruby stuff. I seriously need to finish the document class inheritance stuff so we can enforce package scope where it belongs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1214
The only problem right now is this doesn't actually work and I don't understand why. I tried adding it to the whole document verbatim:font command and also adding it inside the specific verbatim block in question, nothing is actually working.