-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lightweight enumerations and bullet lists #1365
Merged
alerque
merged 6 commits into
sile-typesetter:master
from
Omikhleia:enumitem-lite-package
Jun 22, 2022
Merged
Lightweight enumerations and bullet lists #1365
alerque
merged 6 commits into
sile-typesetter:master
from
Omikhleia:enumitem-lite-package
Jun 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
added
enhancement
Software improvement or feature request
modules:packages
Issue relates to core or 3rd party packages
labels
Apr 15, 2022
What happened to my review? I know I wrote up something for this a couple days ago ... 🤷 ... forgot to hit "send"? Still have the tab open somewhere? |
alerque
requested changes
May 26, 2022
Omikhleia
force-pushed
the
enumitem-lite-package
branch
from
June 19, 2022 01:34
8913de3
to
ca74ed6
Compare
Moving on:
Next tasks to come:
|
Omikhleia
force-pushed
the
enumitem-lite-package
branch
from
June 19, 2022 11:51
ca74ed6
to
948c317
Compare
Omikhleia
force-pushed
the
enumitem-lite-package
branch
from
June 19, 2022 22:55
948c317
to
6415e48
Compare
Moving on:
|
alerque
approved these changes
Jun 21, 2022
Thanks for all the refactoring on this, and sorry it was such a long haul for a relatively simple thing. I'm much happier with the state now and think this package will get a lot of millage in the wild. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Software improvement or feature request
modules:packages
Issue relates to core or 3rd party packages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am proposing here a lightweight enumeration and bullet list package, with two aims in mind:
It is, actually, a "trimmed-down" version of the feature-rich but more experimental "enumitem" package I have in my own repository (https://github.com/Omikhleia/omikhleia-sile-packages). By "trimmed-down", I mean it doesn't use my experimental (and as-of-yet unfinished) "styles" system and has a bit less flexibility (with respect to customization, etc.). But otherwise it supports the same types of settings and has the same default general appearance (and also shares a good number of non-regression tests). So at this point at least, it's compatible with the things I have been using on my side for some months now.
As can be seen in the implementation, I tried to make it as robust as possible with respect to structure, paragraph skips, outer and inner parskips, as well as proper nesting. Regarding the latter, it supports two ways of nesting, a simple one (but less powerful) and a more powerful one (which, for the record, is what I now use for converted markdown in my unpublished proof-of-concept attempts, but at least you now know I tried to ensure I could use it in that context!).
Tuning the beast proved a bit hard, hence the number of tests. Are there too many tests? I can't say, except that each of them was added after I found a potential bug that wouldn't break the previous ones, or to check a documentation claim was indeed honored.