Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Catalan hyphenations at geminated L #1964

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

Omikhleia
Copy link
Member

Closes #1961

Instal·lem SILE per a la llengua catalana!

And we are in advance, but happy Dia del Punt Volat on January 24 to our Catalan friends.

@Omikhleia Omikhleia added the bug Software bug issue label Jan 21, 2024
@Omikhleia Omikhleia self-assigned this Jan 21, 2024
@Omikhleia Omikhleia added this to the v0.14.15 milestone Jan 21, 2024
alerque
alerque previously approved these changes Jan 21, 2024
Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my only concern with this and the other PR is the size of the test case. I would prefer if we could get in on A7 and adjust the font metrics until we had just a couple words and and absolute minimum of lines to exhibit the actual test subject. That makes it a lot easier to review both diffs of the debug file and the actual display PDF later when some minor metrics change affects things. These long lines on big pages add up to a lot of content to review hunting for the one syllable difference that may or may not matter.

@Omikhleia
Copy link
Member Author

I think my only concern with this and the other PR is the size of the test case

I amended my test commit to make it smaller and on A7

image

Would that be sufficient?

  • Line 1 and 3 show hyphenations in the segments resp. after and before the geminated L (to check replacement worked)
  • Line 2 shows hyphenation at the segment with the geminated L (to check prebreak worked)
  • Sequence repeated with the precomposed characters.

@alerque
Copy link
Member

alerque commented Jan 22, 2024

If I understand the test correctly the fixup commit I just sent should accomplish the same thing, save about 30 lines of diffs, and also be a lot easier to visually inspect later to see if the proper thing is still being tested. Can you give that a check to make sure I understood it correctly?

@Omikhleia
Copy link
Member Author

Can you give that a check to make sure I understood it correctly?

Looks good to me!

@alerque alerque merged commit 60b95d7 into sile-typesetter:master Jan 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyphenation on Catalan words containing geminated L
2 participants