Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(packages): Remove unused typesetter-scoped cursor tracking #1981

Merged

Conversation

Omikhleia
Copy link
Member

@Omikhleia Omikhleia commented Feb 2, 2024

This was present since the very first commit of the raiselower package, but we do not have any use of such a thing anywhere else in the code base.

I think we can safely remove it...

I noticed it a while back, and remembered it when checking whether this raise/lower commands should use the new liners (the answer that question would be "no", it doesn't seem to me this case meets the criteria).

Another question, then should come its own issue shortly afterwards,.. I can tease it here, though:
Regarding the signature of ouputYourself methods, why do we still need the typesetter at output time? It's job ought to be finished then! All we seem to need is... the frame. (I'm still checking the code to check if there is any counter-argument).

This was present since the very first commit of the raiselower
package, but we do not have any use of such a thing anywhere else
in the code base.
@Omikhleia Omikhleia added the refactor Code quality improvements label Feb 2, 2024
@Omikhleia
Copy link
Member Author

This was present since the very first commit of the raiselower package

That is a02848e from 2014, and as can be seen there in other commands, at the time the cursor was in the typesetter state and there was no frame yet. The shift to frames occurred in a6ad32c later in 2014 -- but this small bit here was likely overlooked.

@alerque
Copy link
Member

alerque commented Feb 7, 2024

Another question, then should come its own issue shortly afterwards,.. I can tease it here, though:
Regarding the signature of ouputYourself methods, why do we still need the typesetter at output time? It's job ought to be finished then! All we seem to need is... the frame. (I'm still checking the code to check if there is any counter-argument).

I think we're very close to being able to say "we don't". There used to be a lot of reasons we did need it, but I've been whittling away at them and I think the blockers are almost all gone.

@alerque alerque merged commit 23697f9 into sile-typesetter:master Feb 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code quality improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants