-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only call 'noindent' if language is English in book commands #1991
Conversation
efadfc5
to
bc24162
Compare
bc24162
to
021f524
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, sorry that source comment is misleading. This is not an "English" feature, it is quite a common default for many languages that use Latin based orthographies. For example Turkish ;-)
The more relevant point is that there are a handful of languages that specifically eschew this: French being a notable one. I think the correct approach here will be to make this behavior have a per-language default. That isn't easy to do right no because of the chaotic overlap in scopes for the language modules, but I'm actually refactoring that right now and am hopeful we'll have a better place to "hang this hat" soon. I'll leave this PR around as a reminder of the issue and we'll update it to to the right thing when there is a sensible way to do so.
And I might be mistaken, but usage depends on conventions that are not strictly language-specific (i.e. there could be a language-specific default, but it would likely need to be something the user can configure) |
Right, things aren't as simple as they look sometimes...
yeah, I thought about that, and I really think that we should discuss further the implementation of a basic styling paradigm in SILE, this is essencial for typesetting! |
An interesting discussion on the topic: https://tex.stackexchange.com/a/39232 (The whole discussion mentions typographers such as Bringhurst, Tschichold; and the French Imprimerie Nationale -- all sorts of lectures I personally like) There could be a language-specific default, thus... |
This old PR now has conflicts, and last discussions pointed it would not occur as-is. |
Since it's a English feature it shouldn't be called if
document.language
isn't English as well...