Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make document state available during class's post init #2095

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

alerque
Copy link
Member

@alerque alerque commented Aug 24, 2024

Fixes #2083, although I'm unsure if this is actually a fundamental improvement or if it just makes a bigger mess of variable scopes. Catching the error and suggesting preambels might be a better route.

@alerque alerque added this to the v0.15.5 milestone Aug 24, 2024
@alerque
Copy link
Member Author

alerque commented Aug 29, 2024

I'm going to go ahead with this "fix". It still isn't ideal, but whether we're munging some global state variable from the inputter or the class doesn't seem to be consequential. The right answer is to stop munging global state, but this makes more sense to me and should make eventually refactoring it out entirely that much easier to accomplish.

I do not think this change is the right way to "fix" the issue in #2083, that should still be done with a preamble. But it does "fix" the issue in that we document what the related API is for.

@alerque alerque marked this pull request as ready for review August 29, 2024 14:07
@alerque alerque added bug Software bug issue documentation Documentation bug or improvement issue labels Aug 29, 2024
@alerque alerque merged commit 2d65a45 into sile-typesetter:master Aug 29, 2024
18 of 20 checks passed
@alerque alerque deleted the class-post-init branch August 29, 2024 14:18
@Omikhleia Omikhleia mentioned this pull request Aug 29, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software bug issue documentation Documentation bug or improvement issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there anything like a start hook?
1 participant