Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove result in UI after executed #186

Merged
merged 13 commits into from
Oct 26, 2024
Merged

Remove result in UI after executed #186

merged 13 commits into from
Oct 26, 2024

Conversation

doombeaker
Copy link
Collaborator

之前考虑方便,LLM、VLM、JoyCaption 出的文字,不仅会返回到 python 后端,还会更新到前端的 node UI 上。

不过,因为 ComfyUI 的 Cache 机制,会把每次 node UI 上的内容,全部算做 input,做 hash 后,来决定是否需要重新执行 node,且优先级是高于可以重写的 IS_CHANGED

也就是说,如果每次更新 UI,则 node 就没有 cache 机制。

经过考虑和用户反馈,我们还是不更新 UI 了,cache 可以省掉不必要的运算,收益更大。

Copy link

Your code does not meet the Black formatting standards.
Please run python3 -m pip install -r dev_requirements.txt && pre-commit install && pre-commit run --all-files to format your code.

@doombeaker doombeaker merged commit d192239 into master Oct 26, 2024
4 checks passed
@doombeaker doombeaker deleted the remove_result_in_ui branch October 26, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant