Merge pull request #82 from silinternational/golangci-lint

run more checks in golangci-lint

.golangci.yaml

@@ -0,0 +1,19 @@
+run:
+    timeout: 2m
+linters:
+    enable:
+    - errcheck
+    - gosimple
+    - govet
+    - ineffassign
+    - staticcheck
+    - unused
+    - bodyclose
+    - exhaustive
+    - gocheckcompilerdirectives
+    - godox
+    - gofmt
+    - goimports
+    - gosec
+    - whitespace
+    - usestdlibvars

functional_test.go

@@ -87,7 +87,7 @@ func sendRequest(url string, c *http.Cookie) error {
 func weSendARequestWithAuthorizationDataAuthorizingAccess(where, level string) error {
 	var c *http.Cookie
 	url := p.Host
-	expires := time.Now().Add(1000 + time.Second*time.Duration(rand.Intn(1000)))
+	expires := time.Now().Add(1000 + time.Second*time.Duration(rand.Intn(1000))) // #nosec G404 weak random number is OK
 	token := makeTestJWT(p.Secret, level, expires)
 
 	if where == "cookie" {

main.go

@@ -343,7 +343,7 @@ func (p Proxy) getNewToken(w http.ResponseWriter, r *http.Request) error {
 
 func (p Proxy) getTokenFromAPI(ipAddress string) string {
 	client := &http.Client{Timeout: time.Second * 10}
-	req, err := http.NewRequest("GET", p.ManagementAPI+p.TokenPath, nil)
+	req, err := http.NewRequest(http.MethodGet, p.ManagementAPI+p.TokenPath, nil)
 	if err != nil {
 		p.log.Error("error creating management API request", zap.Error(err))
 		return ""
@@ -356,6 +356,7 @@ func (p Proxy) getTokenFromAPI(ipAddress string) string {
 		return ""
 	}
 
+	defer resp.Body.Close()
 	token, err := io.ReadAll(resp.Body)
 	if err != nil {
 		p.log.Error("failed to read management API response", zap.Error(err))

main_test.go

@@ -16,7 +16,7 @@ import (
 
 func Test_AuthProxy(t *testing.T) {
 	const managementAPI = "http://management_api.example.com"
-	const tokenPath = "/auth/token"
+	const tokenPath = "/auth/token" // #nosec G101 this is not a hardcoded credential
 
 	cookieName := "_test"
 	tokenSecret := []byte("secret")