failed Release 10.3.0 #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…node-version use node 18
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Support everything that TextFieldWithLabel adds to ui-components/TextField so we can deprecate Cover/TextFieldWithLabel
- [x] Insert {description} as Helper Text. Show it by default with mdc-text-field-helper-text--persistent.
- [x] When a validation condition makes it appropriate to show different helper text, replace the description and apply mdc-text-field-helper-text--validation-msg.
- [x] Display a required indicator (e.g. icon or asterisk) when <input> has the :required attribute. You don't need a .required CSS class if you select on :required {}.
[CVR-646 Deprecate TextFieldWithLabel and improve TextField](https://itse.youtrack.cloud/issue/CVR-646/Deprecate-TextFieldWithLabel-and-improve-TextField)
…/word-wrap-1.2.4 build(deps-dev): bump word-wrap from 1.2.3 to 1.2.4
hobbitronics
requested review from
briskt and
a team
and removed request for
briskt
…ion-as-helper Feat/text field description as helper
|
What is a "non-release merge to main"? It seems contradictory to me. |
|
It just means it won't be published to npm by semantic release. I think
there are now publish commits in develop now so I'll update this.
…On Fri, Aug 25, 2023, 12:00 AM briskt ***@***.***> wrote:
What is a "non-release merge to main"? It seems contradictory to me.
—
Reply to this email directly, view it on GitHub
<#213 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQ34VPZ2VSE76MMGI3DPICTXW5QR5ANCNFSM6AAAAAA32Q4RQI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Even though I technically opened it, the releasable changes here are by Alex, so I am going to approve this and merge. |
|
🎉 This PR is included in version 10.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Added