Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReviewEntries] Persist column order/visibility state in project #3309

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 15, 2024

Resolves #3305

This change is Reviewable

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 56.25000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 74.71%. Comparing base (8802659) to head (6bc38e6).

Files Patch % Lines
src/components/Project/ProjectReducer.ts 9.09% 10 Missing ⚠️
src/components/Project/ProjectActions.ts 50.00% 2 Missing ⚠️
...c/goals/ReviewEntries/ReviewEntriesTable/index.tsx 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3309      +/-   ##
==========================================
- Coverage   74.77%   74.71%   -0.07%     
==========================================
  Files         278      278              
  Lines       10708    10736      +28     
  Branches     1291     1293       +2     
==========================================
+ Hits         8007     8021      +14     
- Misses       2337     2351      +14     
  Partials      364      364              
Flag Coverage Δ
backend 83.89% <ø> (ø)
frontend 66.71% <56.25%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review August 15, 2024 21:18
@imnasnainaec imnasnainaec changed the title [ReviewEntries] Persist column order/visibility state [ReviewEntries] Persist column order/visibility state in project Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ReviewEntries] Remember which columns the user hid
1 participant