Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BK throws exception if video output folder doesn't exist #178

Closed
megahirt opened this issue Aug 3, 2021 · 0 comments · Fixed by #185
Closed

BK throws exception if video output folder doesn't exist #178

megahirt opened this issue Aug 3, 2021 · 0 comments · Fixed by #185
Assignees
@Hiro-Nakamura
Labels
bug Something isn't working
Milestone
v1.0 release cand...

Comments

@megahirt
Copy link
Collaborator

megahirt commented Aug 3, 2021

The video output folder path is specified in the settings menu.

image

If the path doesn't exist, the application throws an error.

A fix should create the folder first if it doesn't exist.
@megahirt megahirt added the bug Something isn't working label Aug 3, 2021
Hiro-Nakamura pushed a commit that referenced this issue Aug 3, 2021
[fix] #178 Make sure output directory exists before running the conve…
f0c0e06 
…rsion
irahopkinson pushed a commit that referenced this issue Aug 3, 2021
@Hiro-Nakamura
[fix] #178 Make sure output directory exists before running the conve…
62a58eb 
…rsion (#185)

Co-authored-by: Johnny Hausman <johnny@hausmanfamily.com>
@irahopkinson irahopkinson linked a pull request Aug 3, 2021 that will close this issue
fix #178 Make sure output directory exists before running the conv… #185
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hiro-Nakamura Hiro-Nakamura

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.0 release candidate
Development

Successfully merging a pull request may close this issue.

fix #178 Make sure output directory exists before running the conv… sillsdev/bible-karaoke
3 participants
@megahirt @Hiro-Nakamura @irahopkinson