SF-2480 Remove revision number from product version

[RaymondLuong3]

I couldn't find a way to drop the revision number from the product version in our build steps, so I do a split on the product version. If there is a better way, I am happy to learn.

---

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.85%. Comparing base (3ffeb97) to head (e869522).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2361   +/-   ##
=======================================
  Coverage   75.85%   75.85%           
=======================================
  Files         478      478           
  Lines       27885    27885           
  Branches     4590     4590           
=======================================
  Hits        21151    21151           
  Misses       6012     6012           
  Partials      722      722           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pmachapman]

It turns out this is caused by a feature introduced quietly into the .NET 8.0 SDK, and affects the building of .NET 8.0 and .NET 6.0 binaries.

I disabled it by adding this line to SIL.XForge.Scripture.csproj:

    <IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>

But you might want to take a look at dotnet/sdk#34568 and determine the best way to resolve it. Perhaps via a Directory.Build.props file in the repo root? - see dotnet/sdk#34568 (comment)

I can potentially see the benefit of this version hash for dev environments (notice how it gets recorded in sync_metrics in MongoDB), but I think it might be more hassle than it is worth?

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved

[RaymondLuong3]

Wow, I wish I had thought about googling this. Seems like there are people who are not a fan of how this feature was rolled out. I've added the Directory.Build.props file with instructions to disable this feature. I agree, I don't see much benefit having the version number visible for dev environments.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @pmachapman)

[pmachapman]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RaymondLuong3)