Pass Cloudinary URL as a build-time argument

silvenon · Mar 30, 2024 · bf208da · bf208da
1 parent 47d96b2
commit bf208da
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -154,18 +154,16 @@ jobs:
           field: "app"
 
       - name: Set up Fly
-        uses: superfly/flyctl-actions/setup-flyctl@1.5
-        env:
-          CLOUDINARY_URL: ${{ secrets.CLOUDINARY_URL }}
+        uses: superfly/flyctl-actions/setup-flyctl@master
 
       - name: Deploy Staging
         if: ${{ github.ref == 'refs/heads/dev' }}
-        run: flyctl deploy --remote-only --build-arg COMMIT_SHA=${{ github.sha }} --app ${{ steps.app_name.outputs.value }}-staging
+        run: flyctl deploy --remote-only --build-arg COMMIT_SHA=${{ github.sha }} --build-arg CLOUDINARY_URL=${{ secrets.CLOUDINARY_URL }} --app ${{ steps.app_name.outputs.value }}-staging
         env:
           FLY_API_TOKEN: ${{ secrets.FLY_API_TOKEN }}
 
       - name: Deploy Production
         if: ${{ github.ref == 'refs/heads/main' }}
-        run: flyctl deploy --remote-only --build-arg COMMIT_SHA=${{ github.sha }} --app ${{ steps.app_name.outputs.value }}
+        run: flyctl deploy --remote-only --build-arg COMMIT_SHA=${{ github.sha }} --build-arg CLOUDINARY_URL=${{ secrets.CLOUDINARY_URL }} --app ${{ steps.app_name.outputs.value }}
         env:
           FLY_API_TOKEN: ${{ secrets.FLY_API_TOKEN }}
diff --git a/Dockerfile b/Dockerfile
@@ -24,12 +24,14 @@ RUN npm prune --omit=dev
 # Build the app
 FROM base as build
 
+ARG CLOUDINARY_URL
+
 WORKDIR /app
 
 COPY --from=deps /app/node_modules /app/node_modules
 
 COPY . .
-RUN npm run build
+RUN CLOUDINRAY_URL=${CLOUDINRAY_URL} npm run build
 
 # Finally, build the production image with minimal footprint
 FROM base