Mark the page as changed on setText #1085
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue where the syscall editor.setText() would not cause the page to save. In fact, it doesn't mark the page as changed at all, which means navigating away from the page wouldn't even trigger the save since it won't save unless there are changes:
web/client.ts line 660:
This means that even the "Remove Completed Tasks" function from the tasks plug will lose its changes if you navigate away. Only thing I'm not totally sure about here is whether we should also include this client.save() call or just let it be handled either manually by the userdev or by the auto-save but then that won't trigger until the page is navigated away from.