Update dependencies for Silverstripe 5. Update webpack build and dependencies #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrispenny
force-pushed
the
feature/silverstripe-5
branch
9 times, most recently
from
bf01560 to
a255156
Compare
chrispenny
force-pushed
the
feature/silverstripe-5
branch
from
a255156 to
89200fa
Compare
MelissaWu-SS
approved these changes
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionProcessingState
Rather than setting local state onto the Extension/model, I've created a singleton class that can be used to track when a Job is processing.
This is technically a breaking change, since the
getIsPublishJobRunning(), etc methods were public.Tagging
To run recipe testing for Silverstripe 5, the minimum requirement must be Silverstripe 5. So we can't support both majors at the same time - if we want to use the current recipe testing matrix.
Node/Webpack/etc
Node 18 is now used. Updated our webpack build and dependencies.