Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported modules list for CMS 6 #342

Open
13 of 15 tasks
emteknetnz opened this issue Nov 25, 2024 · 8 comments
Open
13 of 15 tasks

Update supported modules list for CMS 6 #342

emteknetnz opened this issue Nov 25, 2024 · 8 comments

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Nov 25, 2024

Original issue (private) https://github.com/silverstripeltd/product-issues/issues/884

The list of modules loosing commercial support was decided internally within Silverstripe Ltd

Note: At the time this issue is created this list isn't 100% final, though it's unlikely to deviate too much from what's listed here

Modules loosing support though will release a 6.0.0 version with CMS 6 then remove from sink

  • silverstripe/blog
  • silverstripe/subsites
  • silverstripe/crontask

Modules loosing support

  • bringyourownideas/silverstripe-composer-update-checker
  • bringyourownideas/silverstripe-maintenance
  • cwp/agency-extensions
  • cwp/starter-theme
  • cwp/watea-theme
  • silverstripe/recipe-authoring-tools
  • silverstripe/recipe-blog
  • silverstripe/recipe-collaboration
  • silverstripe/recipe-content-blocks
  • silverstripe/recipe-form-building
  • silverstripe/recipe-reporting-tools
  • silverstripe/recipe-services
  • silverstripe/campaign-admin
  • silverstripe/auditor
  • silverstripe/contentreview
  • silverstripe/documentconverter
  • silverstripe/elemental-bannerblock
  • silverstripe/elemental-fileblock
  • silverstripe/environmentcheck
  • silverstripe/externallinks
  • silverstripe/iframe
  • silverstripe/ldap
  • silverstripe/registry
  • silverstripe/restfulserver
  • silverstripe/security-report
  • silverstripe/sitewidecontent-report
  • silverstripe/versionfeed
  • silverstripe/webauthn-authenticator
  • symbiote/silverstripe-multivaluefield

Modules to be copied into silverstripe/reports

  • silverstripe/externallinks
  • silverstripe/security-report
  • silverstripe/sitewide-content-report

New issues created

Acceptance criteria:

  • Notes in the CMS 6 docs or changelogs referencing the modules which won't be CMS 6 compatible are removed
  • silverstripe/supported-modules is updated
  • silverstripe/recipe-kitchen-sink is updated
  • https://docs.silverstripe.org/en/6/project_governance/supported_modules/ (CMS 6 version of page) is updated
  • 6.0.0 changelog calls out which modules are loosing support
  • Existing CMS 6 branches are retained (excluding if being copied into silverstripe/reports)
  • Relevant code is copied into silverstripe/reports and has its namespaces updated
  • 6.0.0 changelogs call out modules copied to silverstripe/reports and updated namespaces
  • Supported badges are removed from README.md on the CMS 6 branches
  • Rhino does not display CI status for CMS 6 branches
  • Ensure that CI crons stop running for unsupported CMS 6 branches when CMS 6 is released (new issue)
  • Automatic merge-ups no longer merge-up to unsupported branches
  • Rhino does not display merge-up status for CMS 6 branches
  • Modules not loosing support until CMS 6 are still released with CMS 6
  • Create a new issue to remove support for modules not loosing support until CMS 6 when CMS 6 has been released

CMS 5 PRs

Kitchen sink CI

CMS 6 PRs

This was referenced Nov 25, 2024
@GuySartorelli
Copy link
Member

Need to remove unsupported modules from the sources-*.js files in https://github.com/silverstripe/doc.silverstripe.org

@GuySartorelli
Copy link
Member

Still need to remove references to these modules from docs. E.g. You can also keep track of new releases through the CMS UI by installing the [maintenance module](https://github.com/bringyourownideas/silverstripe-maintenance), in https://docs.silverstripe.org/en/6/contributing/release_process/#keeping-track, recipe-blog mentioned in the recipes page, campaign admin mentioned in a few places.... and that's just the few I checked.

@GuySartorelli
Copy link
Member

GuySartorelli commented Nov 26, 2024

silverstripe/assets has a hide_in_campaigns config in the SilverStripe\Assets\Shortcodes\FileLink class that needs to be removed. Check for any other references to that config as well.

There's also a reference to campaign admin in the readme of recipe-plugin

The SilverStripe\Versioned\ChangeSet model and its associated tests have a bunch of references to campaigns.

  • Change the singular and plural name to "Changeset" and "Changesets"
  • Remove the CMS_ACCESS_CampaignAdmin permission
  • Update phpdocs that refer to campaigns
  • Evaluate if there's a quick win way to remove changesets, though they're so heavily embedded in recursive publishing my suspicion is we can't do that easily enough to be worth the effort.

@emteknetnz
Copy link
Member Author

emteknetnz commented Nov 26, 2024

Need a PR to remove the supported badge from:
Need to remove unsupported modules from the sources-*.js
Still need to remove references to these modules from docs

Done

Evaluate if there's a quick win way to remove changeset

Previously looked into this, it's definitely not easy due to recursive publishing. It's more of a Versioning thing that campaign-admin uses, rather than a campaign-admin thing, even though it shouldn't be like this.

silverstripe/assets has a hide_in_campaigns ... etc

Could we perhaps split this one off as a separate card? It's dead code though it doesn't block removing support. Means we can get the sink + alpha sorted quicker

@GuySartorelli
Copy link
Member

GuySartorelli commented Nov 27, 2024

Could we perhaps split this one off as a separate card? It's dead code though it doesn't block removing support. Means we can get the sink + alpha sorted quicker

I think removing campaign-admin related stuff is explicitly part of this card - but if there's a lot of associated code I could be open to that. My assumption is that there will be minimal if any code related to that config.

@emteknetnz
Copy link
Member Author

Actually doesn't look too bad will do in this card

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants