DEP Remove unsupported modules #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/6/remove-support
branch
4 times, most recently
from
70f7f0e
to
1b7b4ad
Compare
15 tasks
GuySartorelli
requested changes
Nov 26, 2024
phpunit.xml.dist
Outdated
| <directory>vendor/silverstripe/gridfieldqueuedexport/tests</directory> | ||
| <directory>vendor/silverstripe/errorpage/tests</directory> | ||
| <directory>vendor/silverstripe/registry/tests</directory> | ||
| <directory>vendor/silverstripe/textextraction/tests</directory> | ||
| <directory>vendor/tractorcow/silverstripe-fluent/tests</directory> | ||
| </testsuite> | ||
|
|
||
| <testsuite name="recipe-ccl"> |
There was a problem hiding this comment.
These recipes aren't around anymore. These should be restructured so that either:
a) similar modules are grouped together in test suites, or
b) test suites are grouped to include roughly the same number of modules, or
c) test suites are grouped so that unit tests take roughly the same amount of time per test suite.
e.g. having hybridsessions in its own suite is a waste of a runner.
emteknetnz
force-pushed
the
pulls/6/remove-support
branch
from
1b7b4ad
to
ba05d2c
Compare
emteknetnz
force-pushed
the
pulls/6/remove-support
branch
from
ba05d2c
to
b6b9295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#342