API Stop using deprecated API #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
emteknetnz
force-pushed
the
pulls/2/stop-using-depr
branch
from
4902373 to
8d7964d
Compare
emteknetnz
commented
Nov 24, 2022
| @@ -95,12 +95,8 @@ public function getFooter() | |||
| return FooterHolder::get_one(FooterHolder::class); | |||
| } | |||
|
|
|||
| /** | |||
| * @deprecated 2.2.0 Use RelatedPagesThrough() instead | |||
There was a problem hiding this comment.
Undeprecating because it's called a lot by templates in the starter theme. Given lots of project will have copied the theme files into their own theme, I think forcing templates to update this to <% loop $RelatedPagesThrough %> (which may not even work, and also just looks weird) is adding too much upgrade friction
emteknetnz
force-pushed
the
pulls/2/stop-using-depr
branch
from
8d7964d to
5542b38
Compare
sabina-talipova
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10545