Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API phpunit9 support #2694

Merged
merged 1 commit into from
Oct 27, 2021
Merged

API phpunit9 support #2694

merged 1 commit into from
Oct 27, 2021

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Oct 11, 2021
Closed
93 tasks
@emteknetnz emteknetnz force-pushed the pulls/4/sapphire-test-nine branch 6 times, most recently from 0839e66 to 1266437 Compare October 19, 2021 01:26
@emteknetnz emteknetnz force-pushed the pulls/4/sapphire-test-nine branch 3 times, most recently from 02b96f0 to b2e9e64 Compare October 19, 2021 22:39
@emteknetnz emteknetnz marked this pull request as ready for review October 22, 2021 00:59
@emteknetnz emteknetnz force-pushed the pulls/4/sapphire-test-nine branch from b2e9e64 to 4e2eaa4 Compare October 27, 2021 04:40
maxime-rainville
maxime-rainville approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merged on green.

@emteknetnz emteknetnz force-pushed the pulls/4/sapphire-test-nine branch 2 times, most recently from 70c0343 to 6358932 Compare October 27, 2021 05:22
maxime-rainville
maxime-rainville approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ... merge on green

@emteknetnz emteknetnz force-pushed the pulls/4/sapphire-test-nine branch from 6358932 to 360fbcd Compare October 27, 2021 21:40
@emteknetnz emteknetnz merged commit e7c49fa into silverstripe:4 Oct 27, 2021
@emteknetnz emteknetnz deleted the pulls/4/sapphire-test-nine branch October 27, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emteknetnz @maxime-rainville @LABCAT