API Stop using deprecated API #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
emteknetnz
force-pushed
the
pulls/4/stop-depr
branch
2 times, most recently
from
c0c2e74 to
236d7af
Compare
emteknetnz
commented
Nov 7, 2022
| @@ -12,8 +12,6 @@ class MigrateSiteTreeLinkingTaskTest extends SapphireTest | |||
| { | |||
| protected static $fixture_file = 'MigrateSiteTreeLinkingTaskTest.yml'; | |||
|
|
|||
| protected static $use_draft_site = true; | |||
There was a problem hiding this comment.
Removed because FunctionalTest::use_draft_site is deprecated. This never actually needed to be set true for the unit test to pass.
emteknetnz
force-pushed
the
pulls/4/stop-depr
branch
6 times, most recently
from
0f593fa to
44411c6
Compare
emteknetnz
commented
Nov 9, 2022
| @@ -25,6 +25,7 @@ | |||
| "silverstripe/reports": "^4.7@dev", | |||
| "silverstripe/siteconfig": "^4.7@dev", | |||
| "silverstripe/versioned": "^1.7@dev", | |||
| "silverstripe/versioned-admin": "^1.7@dev", | |||
There was a problem hiding this comment.
This is required to get CMS page history to work since we've migrated from the deprecated CMS class to the class in versioned-admin
emteknetnz
commented
Nov 9, 2022
| @@ -30,7 +30,7 @@ | |||
| class ZZZSearchFormTest extends FunctionalTest | |||
| { | |||
|
|
|||
| protected static $fixture_file = 'SearchFormTest.yml'; | |||
| protected static $fixture_file = 'ZZZSearchFormTest.yml'; | |||
There was a problem hiding this comment.
Renamed to remove the warning that the filename did not match the class name
sabina-talipova
suggested changes
Nov 15, 2022
emteknetnz
force-pushed
the
pulls/4/stop-depr
branch
2 times, most recently
from
815a556 to
f031025
Compare
sabina-talipova
approved these changes
Nov 16, 2022
|
Require silverstripe/silverstripe-framework#10565 to be merged. |
emteknetnz
force-pushed
the
pulls/4/stop-depr
branch
from
f031025 to
e64bfdb
Compare
|
@sabina-talipova green now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10542
CI won't pass until silverstripe/silverstripe-framework#10565 is merged