API Stop using deprecated API #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
emteknetnz
commented
Nov 7, 2022
| @@ -13,8 +13,6 @@ class ElementControllerTest extends FunctionalTest | |||
| { | |||
| protected static $fixture_file = 'ElementControllerTest.yml'; | |||
|
|
|||
| protected static $use_draft_site = true; | |||
There was a problem hiding this comment.
Removing because FuntionalTest.use_draft_site is deprecated. This never actually needed to be set to true for the unit test to pass
emteknetnz
force-pushed
the
pulls/4/stop-depr
branch
from
dca7a8d to
08be023
Compare
sabina-talipova
approved these changes
Nov 11, 2022
menno-rdmkr
pushed a commit
to busting-bytes/silverstripe-elemental
that referenced
this pull request
Dec 15, 2022
…stop-depr API Stop using deprecated API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10542