Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Allow for custom admin url #1282

Merged

Conversation

PortableSteve
Copy link
Contributor

@PortableSteve PortableSteve commented Nov 26, 2024

Description

Allow inline editable content blocks to be saved when using a custom admin route.

Manual testing steps

  • Set a custom admin route.
  • Add a Content Block to an element area.
  • Make changes to the content block and try to save it.
  • Verify that changes are saved successfully.

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
  • The commit messages follow our [commit message guidelines]
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

Fixes an issue saving inline editable content blocks if a custom admin route was set
@michalkleiner
Copy link
Contributor

Thanks for the PR @PortableSteve, can you please rebase/retarget to 5.3 so it can go out in the next patch release? Thanks!

@PortableSteve
Copy link
Contributor Author

Thanks for the PR @PortableSteve, can you please rebase/retarget to 5.3 so it can go out in the next patch release? Thanks!

Done, thanks!

@michalkleiner
Copy link
Contributor

The change looks good to me, over to @GuySartorelli to merge on green unless there are any other changes/comments.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Michal you do know you're allowed to merge things right? :p

@GuySartorelli GuySartorelli merged commit 6d0fb1e into silverstripe:5.3 Nov 26, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants