Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Compatibility with webonyx/graphql-php v14 #973

Merged
merged 1 commit into from
Apr 13, 2022
Merged

MNT Compatibility with webonyx/graphql-php v14 #973

merged 1 commit into from
Apr 13, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Apr 12, 2022
Closed
@emteknetnz emteknetnz marked this pull request as ready for review April 12, 2022 21:57
GuySartorelli
GuySartorelli requested changes Apr 12, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a FakeResolveInfo class which is newly declared in silverstripe/silverstripe-graphql - should that one be used instead of the one that's in this module? The one in this module should probably be marked deprecated or removed outright imo.

tests/GraphQL/DuplicateElementMutationTest.php Outdated Show resolved Hide resolved
tests/GraphQL/Legacy/AddElementToAreaMutationTest.php Outdated Show resolved Hide resolved
tests/GraphQL/Legacy/SortBlockMutationCreatorTest.php Outdated Show resolved Hide resolved
@GuySartorelli
Copy link
Member

In general I'm happy with this - there's just the outstanding question of whether to use the FakeResolveInfo class which is newly declared in silverstripe/silverstripe-graphql instead of the one in this module. I can't see any reason to keep the one from this module.

@emteknetnz
Copy link
Member Author

I don't think we should refactor anymore than the absolute minimum to get this working given where graphql3 is in its lifecycle.

GuySartorelli
GuySartorelli approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair. I'm happy with this then.

@GuySartorelli GuySartorelli merged commit 3c296e3 into silverstripe:4 Apr 13, 2022
@GuySartorelli GuySartorelli deleted the pulls/4/webonyx branch April 13, 2022 01:28
menno-rdmkr pushed a commit to busting-bytes/silverstripe-elemental that referenced this pull request Dec 15, 2022
@GuySartorelli
Merge pull request silverstripe#973 from creative-commoners/pulls/4/w…
519c7cc 
…ebonyx

MNT Compatibility with webonyx/graphql-php v14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli