Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code in CMS5 for core #10501

Closed
7 of 8 tasks
maxime-rainville opened this issue Sep 9, 2022 · 3 comments
Closed
7 of 8 tasks

Remove deprecated code in CMS5 for core #10501

maxime-rainville opened this issue Sep 9, 2022 · 3 comments

Comments

@maxime-rainville
Copy link
Contributor

maxime-rainville commented Sep 9, 2022

Acceptance criteria

  • Code from the 1/4 branches is merged-up for core modules first
  • All deprecated code is removed for all core modules
  • All unit tests covering deprecated code are removed
  • YML Config is reviewed to make sure it doesn't reference removed code
  • A list of all deprecated methods and classes is added to the CMS5 changelog to help people plan their upgrades
  • recipe-plugin and vendor-plugin are correctly updated (they lack Deprecation::notice())
  • graphql v3 _legacy folders are deleted from asset-admin, elemental, versioned-admin and any others e.g. cms
  • Remove the Serializable interface from classes - https://github.com/silverstripeltd/product-issues/issues/626

Passed tests in CI for silverstripe/installer

PR

More PRs

@GuySartorelli
Copy link
Member

Why would the list of deprecated stuff go to userhelp? Content authors shouldn't be expected to know or care about this.

@emteknetnz emteknetnz self-assigned this Sep 13, 2022
@emteknetnz emteknetnz changed the title Process deprecations in CMS5 Stop using deprecated code in CMS5 for core Oct 12, 2022
@emteknetnz emteknetnz changed the title Stop using deprecated code in CMS5 for core Remove deprecated code in CMS5 for core Oct 12, 2022
@sabina-talipova
Copy link
Contributor

sabina-talipova commented Nov 21, 2022

Merged-up branches:

  • silverstripe-testsession;
  • silverstripe-behat-extension
  • silverstripe-queuedjobs
  • silverstripe-gridfieldextensions
  • vendor-plugin
  • silverstripe-registry
  • silverstripe-elemental
  • silverstripe-graphql
  • silverstripe-config
  • silverstripe-cms
  • silverstripe-campaign-admin
  • silverstripe-asset
  • silverstripe-asset-admin
  • silverstripe-admin
  • silverstripe-versioned-admin
  • silverstripe-versioned
  • silverstripe-siteconfig
  • developer-docs
  • silverstripe-framework

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Dec 8, 2022

Deprecated code was removed. Related to this issue tickets were created. Close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants