Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Restore nullable params #76

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Dec 7, 2022

Issue silverstripe/silverstripe-framework#10501

Few things to tidy up the recently merged config PR linked in the issue above:

  • remove($class, $name = null) was existing functionality to remove an entire config, not just a single key/value for a class - default null paramter has been restroed
  • Refactored string|null to the slightly shorter ?string syntax
  • Converted a stray unserialize() method to __unserialize()
  • Fixed a unit test changing merge() to set() because it was setting a non-array value

@sabina-talipova sabina-talipova merged commit f94cf32 into silverstripe:2 Dec 8, 2022
@sabina-talipova sabina-talipova deleted the pulls/2/set-remove branch December 8, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants