FIX Prevent infinite loops in Deprecation::notice() #10530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2022
emteknetnz
force-pushed
the
pulls/4/prevent-deprecation-loop
branch
2 times, most recently
from
60aba3b to
8089fd9
Compare
GuySartorelli
requested changes
Oct 11, 2022
emteknetnz
force-pushed
the
pulls/4/prevent-deprecation-loop
branch
2 times, most recently
from
0b2f2d5 to
82ee708
Compare
GuySartorelli
requested changes
Oct 12, 2022
emteknetnz
force-pushed
the
pulls/4/prevent-deprecation-loop
branch
from
82ee708 to
1ee0aff
Compare
GuySartorelli
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #10500
Prevent nested Deprecation::notice(), such as in the case of BaseKernel::getEnvironment(), from causing an infinite loop