API Stop using deprecated API #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
emteknetnz
commented
Nov 7, 2022
| @@ -22,12 +24,12 @@ class RegistryPageFunctionalTest extends FunctionalTest | |||
| RegistryPageTestPage::class | |||
| ]; | |||
|
|
|||
| protected static $use_draft_site = true; | |||
There was a problem hiding this comment.
Removing because FuntionalTest.use_draft_site is deprecated. To fix the unit test I just publish all the pages.
emteknetnz
force-pushed
the
pulls/2/stop-depr
branch
from
39e07e3 to
b43e46d
Compare
emteknetnz
commented
Nov 9, 2022
| @@ -25,7 +25,8 @@ | |||
| }, | |||
| "require-dev": { | |||
| "phpunit/phpunit": "^9.5", | |||
| "squizlabs/php_codesniffer": "^3.0" | |||
| "squizlabs/php_codesniffer": "^3.0", | |||
| "silverstripe/versioned": "^1.12" | |||
There was a problem hiding this comment.
Adding this to require-dev so that we can call ->publishRecursive() in unit tests
sabina-talipova
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10542