BUGFIX: Fixed issue #213 causing crash when accessing a translation with a checkbox #215
Conversation
…ith a checkbox
| @@ -1897,7 +1897,7 @@ public function transformFormField(FormField $field) { | |||
| * @param FormField $originalField The original editable field containing the translated value | |||
| * @return CheckboxField The field with a modified label | |||
| */ | |||
| protected function transformCheckboxField(CheckboxField $nonEditableField, CheckboxField $originalField) { | |||
| protected function transformCheckboxField(CheckboxField_Readonly $nonEditableField, CheckboxField $originalField) { | |||
There was a problem hiding this comment.
Now we have the inverse errorwhen a non-readonly CheckboxField is passed in. If using a strict typehint it should match the phpdoc (or alter the phpdoc).
I suggest to just make it FormField.
There was a problem hiding this comment.
Is this parameter even used? It doesn't seem to be even referenced inside the method body.
There was a problem hiding this comment.
Ya i don't think it is, probably only there for compatibility.
|
Both the PHPDoc and the argument name indicate a readonly field. Looking at |
BUGFIX: Fixed issue #213 causing crash when accessing a translation with a checkbox
Currently accessing a translation who's form contains a checkbox results in a crash (issue #213) caused by the first argument being passed is a CheckboxField_Readonly instance which is not a decedent of the CheckboxField class. This pull changes the first argument to expect an instance of CheckboxField_Readonly which allows the form to correctly display.
Generated error prior to this change