Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

MNT Fail tests on warnings #38

Conversation

emteknetnz
Copy link
Member

Issue silverstripe/silverstripe-framework#10250

Unit tests will now fail on deprecation warnings, as well as other less common warnings.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be interesting.
LGTM - is as discussed. Here's hoping there aren't many warnings we've been ignoring.

@GuySartorelli GuySartorelli merged commit ffc62fd into silverstripe:master Apr 26, 2022
@GuySartorelli GuySartorelli deleted the pulls/master/warning-fail branch April 26, 2022 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants