[WIP] GraphQL v4 compat #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed field names to lowercase for forwards compat with GraphQL v4
|
Closing this stale PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196 (when it's ready)
Started with v3.5 compat (lowercase prop names), but then I ran into PHP issues as well and figured it wasn't really worth it. My take is that we should just require GraphQL v4 for this module.
This is work in progress, haven't tackled PHP yet. Will need to be worked alongside with silverstripe/silverstripe-versioned-snapshots#40
Will take some inspiration from the GraphQL v4 rewrites in versioned and versioned-admin:
silverstripe/silverstripe-versioned-admin@721403f
silverstripe/silverstripe-versioned@ebb4c8f
silverstripe/silverstripe-versioned@b6cab40