Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH add CAN_DEV_BUILD to non_live_permissions #426

Merged
merged 1 commit into from
Nov 10, 2023
Merged

ENH add CAN_DEV_BUILD to non_live_permissions #426

merged 1 commit into from
Nov 10, 2023

Conversation

andrewandante
Copy link
Contributor

@andrewandante andrewandante commented Nov 3, 2023 •
edited
Loading

@andrewandante andrewandante mentioned this pull request Nov 3, 2023
Closed
GuySartorelli
GuySartorelli requested changes Nov 3, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@andrewandante andrewandante force-pushed the ENH/add_CAN_DEV_BUILD_permission branch from 7a8088a to 044bdb0 Compare November 5, 2023 20:33
GuySartorelli
GuySartorelli approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as expected. Will merge when the framework PR has been merged.

@GuySartorelli GuySartorelli merged commit 2f335f5 into silverstripe:2 Nov 10, 2023
9 checks passed
@andrewandante andrewandante deleted the ENH/add_CAN_DEV_BUILD_permission branch November 10, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewandante @GuySartorelli