Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Keyspace if missing option #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cleaton
Copy link
Contributor

@cleaton cleaton commented Jan 24, 2021

No description provided.

@cleaton
Copy link
Contributor Author

cleaton commented Mar 7, 2021

Maybe it's preferable to always first connect without keyspace and run the keyspace creation CQL before connecting to the keyspace.

@csrl
Copy link
Contributor

csrl commented Oct 15, 2021

Hi @silviucpp , what do you think of this PR? It would be useful for us. Is there a change that you want done?

@silviucpp
Copy link
Owner

This PR needs a bit of changes.

First we need to get rid of representing strings as lists.there are few places like the following (_ -> "")

            Keyspace = case erlcass_utils:get_env(keyspace) of
                {ok, Space} -> Space;
                _ -> ""
            end,

In the entire library we are working with binary strings and I want to keep it consistent.

Also this PR doesn't have a unit test added for this case.

In case this things are fixed I can merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants