Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid assigning partitions if consumer is not running #60

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

macasado86
Copy link
Contributor

Hi!

We are having some problems when trying to stop multiple clients of the same consumer group concurrently. We have seen that in some occasions, we are receiving partition assignment requests (I guess due to rebalancing when stopping another client) on clients that already have the running flag set to false. This is preventing the client from being completely stopped (and I think generating a deadlock by not releasing all the rd_kafka objects).

I have included a check in the assignment method to verify that the client is not running (same mechanism as in the revoke partitions function).

@silviucpp silviucpp merged commit 011b00b into silviucpp:master Jun 28, 2023
@silviucpp
Copy link
Owner

Thanks for fixing. you are right regarding the fix !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants