Remove obsolete type guards and fix axes attribute creation
#379
Conversation
| } & ( | ||
| | { axes: T; axesAttr: (Extract<keyof T, string> | '.')[] } | ||
| | { axes?: never; axesAttr?: never } | ||
| ) & |
There was a problem hiding this comment.
Changing my mind on this. I think inlining is clearer after all. 🤷♂️
The change below also required a slight change in typing: Extract<keyof T, string> instead of keyof T, as keyof T resolves to string | number | Symbol as explained in microsoft/TypeScript#23724 (comment) ... even though T is Record<string, ...>! This seems very odd... there's a comment about it in the linked PR, but no answer.
There was a problem hiding this comment.
Probably keyof does not behave well with templates ? 🤷
There was a problem hiding this comment.
Generics you mean? The guy's comment on microsoft/TypeScript#23724 (comment) doesn't mention a generic so I don't think it's related.
There was a problem hiding this comment.
Link to the comment: microsoft/TypeScript#23724 (comment)
No description provided.