-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to React v17 and R3F v6 #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loichuder
approved these changes
Apr 13, 2021
axelboc
commented
Apr 16, 2021
loichuder
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much to say: well done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time for the React v17 and R3F v6 upgrade! There are still a bunch of peer-deps warnings, but much fewer than before.
No changes from React 17, of course, but R3F had a bunch of breaking changes, not all of which were documented...
Notable improvements:
attach="material"
andattach="geometry"
.useThree
is now based on zustand, so we can pass it a selector to avoid unnecessary re-renders. When we need to get multiple properties from the state, I chose to write separateuseThree(state => state.prop)
calls instead of using zustand'sshallow
comparator. Having separate calls allows for destructing the objects we get, likesize
,camera
, etc. right away.Other notable upgrades:
d3-array
has a fix tod3.ticks
that may benefit us somewhere.any
. I've had to fix a few of those.controls
add-on handles JSON arguments much better:Planned work:
useUpdate
has been deprecated, so the code inErrorBars
is not as readable. I think there's a way to make this component more declarative by passing an array of floats directly to<bufferGeometry args={[positions]} />
instead of callingsetFromPoints()
imperatively. Same inDataCurve
.LineVis
andHeatmapVis
with a hook calleduseTooltipFormatters
. I might give that a try.