Fix: Datasets with many rows fail to load due to incorrect variable type #3926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type was already an int.
|
Thanks a lot for that fix. |
|
Be careful i have sckatched your changes |
|
Thanks for the fix! That can also depends on pyqt versions, and it's not something we're getting into so often. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3925
MAX_NUMBER_OF_ROWSis defined with a float literal, thus if a dataset has more thanMAX_NUMBER_OF_ROWS,rowCount()returns afloatinstead ofintand the dataset does not load.Fix
Set limits as integers, not floats.