Skip to content

Commit

Permalink
Fix some things in the way deps are specified
Browse files Browse the repository at this point in the history
* ethers was missing from contracts/* packages' dep list;
* pnpm does not install peer deps automatically and in general it makes
  sense for orclient and ortypes to have some deps like ethers as direct
deps specified since they won't work without them. So now specifying
these deps both as deps and peer deps. Checkout out [this](npm/rfcs#324) for how it should work.
  • Loading branch information
sim31 committed Nov 18, 2024
1 parent 7977179 commit 41d2999
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 6 deletions.
3 changes: 2 additions & 1 deletion contracts/orec/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@
},
"dependencies": {
"@openzeppelin/contracts": "^5.0.2",
"dotenv": "^16.4.5"
"dotenv": "^16.4.5",
"ethers": "^6.13.4"
},
"publishConfig": {
"access": "public",
Expand Down
3 changes: 2 additions & 1 deletion contracts/respect1155/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@
},
"dependencies": {
"@openzeppelin/contracts": "^5.1.0",
"@ordao/orec": "^1.0.9"
"@ordao/orec": "^1.0.9",
"ethers": "^6.13.4"
},
"publishConfig": {
"access": "public",
Expand Down
3 changes: 3 additions & 0 deletions libs/orclient/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@
},
"dependencies": {
"@ordao/ts-utils": "^1.0.5",
"@ordao/ortypes": "^1.0.3",
"ethers": "^6.13.0",
"zod": "^3.23.8",
"chai": "^5.1.1",
"tsconfig-to-dual-package": "^1.2.0",
"zod-to-json-schema": "^3.23.1"
Expand Down
4 changes: 3 additions & 1 deletion libs/ortypes/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,10 @@
"@ordao/orec": "^1.0.9",
"@ordao/respect1155": "^1.0.9",
"@ordao/ts-utils": "^1.0.5",
"chai": "^5.1.1",
"op-fractal-sc": "github:Optimystics/op-fractal-sc#main",
"ethers": "^6.13.0",
"zod": "^3.23.8",
"chai": "^5.1.1",
"tsconfig-to-dual-package": "^1.2.0",
"utility-types": "^3.11.0"
},
Expand Down
3 changes: 3 additions & 0 deletions libs/privy-react-orclient/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@
"@privy-io/react-auth": "^1.93.0",
"react": "^18.3.1"
},
"dependencies": {
"@ordao/orclient": "^1.0.6"
},
"keywords": [
"ordao",
"orclient",
Expand Down
16 changes: 13 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 41d2999

Please sign in to comment.