Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query variables stopped working with 0.4.0 #230

Closed
silentZaika opened this issue Feb 16, 2022 · 11 comments
Closed

Query variables stopped working with 0.4.0 #230

silentZaika opened this issue Feb 16, 2022 · 11 comments

Comments

@silentZaika
Copy link

After upgrading to the plugin version 0.4.0 with Grafana 8.3.6 (and 8.3.5), the query variable are not populated from JSON datasource.

@simPod
Copy link
Owner

simPod commented Feb 16, 2022 via email

@silentZaika
Copy link
Author

Well, I had a query variable working with JSON datasource, returning an array of strings. After the plugin upgrade, it stopped working, just had "None".
Reverted back to 0.3.0 plugin version, and it works.
Am I missing something here?

@simPod
Copy link
Owner

simPod commented Feb 17, 2022

Working with variables changed since 0.4. Have you checked release notes? Can you provide some details, what are of strings do you expect?

@silentZaika
Copy link
Author

I checked release notes, but they don't mention what exactly changed.
I have a JSON datasource, which is used to populate a query variable with values e.g. "string1," "string2", "string3" values. JSON datasource connects to a web service, that based on the target value in the payload, replies with ["string1," "string2", "string3"].

@simPod
Copy link
Owner

simPod commented Feb 17, 2022

Variable query calls /query with provided payload as shown in https://github.com/simPod/GrafanaJsonDatasource/releases/tag/0.4.0. Does your backend accept the request?

@silentZaika
Copy link
Author

Oh, sorry. I didn't specify it. I have the setup as described in the documentation for /search here https://github.com/simPod/GrafanaJsonDatasource/tree/0.4.0#search

@simPod
Copy link
Owner

simPod commented Feb 17, 2022 via email

@silentZaika
Copy link
Author

Well, it might be more flexible, but why fix something that has not been broken)
Also, the documentation suggests that /search still works.

@simPod
Copy link
Owner

simPod commented Feb 17, 2022 via email

@simPod
Copy link
Owner

simPod commented Feb 18, 2022

I've edited release notes to include information about variables calling another endpoint. Thanks.

@simPod simPod closed this as completed Feb 18, 2022
@simPod
Copy link
Owner

simPod commented Feb 21, 2022

My bad, it calls /variable endpoint (#231)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants